Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #1811

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Upgrade dependencies #1811

merged 8 commits into from
Jul 10, 2024

Conversation

jpraynaud
Copy link
Member

Content

This PR includes an ugprade of the dependencies of the repository:

  • Rust dependencies
  • Documentation website
  • mithril-client-wasm/www website
  • mithril-client-wasm/www-test website

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1810

@jpraynaud jpraynaud self-assigned this Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   8m 55s ⏱️ +4s
1 145 tests ±0  1 145 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 311 runs  ±0  1 311 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0869a7c. ± Comparison against base commit 640ee4d.

♻️ This comment has been updated with latest results.

dlachaume
dlachaume approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To upgrade mithril-client-wasm JS packages www and www-test, I'd suggest to run this command instead:
cd mithril-client-wasm && make upgrade-www-deps

Do we need to runnix flake update too?

@jpraynaud
fix: libp2p error following update
09592b4 
Error message: 'Server cert key DER is valid; qed: InvalidCertificate(Other(OtherError(UnsupportedCriticalExtension)))'
Fixed by running: 'cargo update -p rustls@0.23.11 --precise 0.23.10' and 'cargo update -p rustls-webpki@0.102.5 --precise 0.102.4'
Issue followed by libp2p/rust-libp2p#5487
@jpraynaud
chore: update nix flake dependencies
0869a7c 
By running 'nix flake update' command.
@jpraynaud
Copy link
Member Author

To upgrade mithril-client-wasm JS packages www and www-test, I'd suggest to run this command instead: cd mithril-client-wasm && make upgrade-www-deps

I created this issue to document and standardize the dependencies upgrade process: #1813
The new run book will be the perfect place to put this information 🙂

Do we need to runnix flake update too?

I added the upgrade for nix 👍

@jpraynaud jpraynaud merged commit 6756b0f into main Jul 10, 2024
41 of 42 checks passed
@jpraynaud jpraynaud deleted the 1810-upgrade-dependencies branch July 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume